On Tue, 23 Jun 2026 21:28:19 GMT, Paul Sandoz <[email protected]> wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments resolution
>
> test/jdk/jdk/incubator/vector/Float16Vector128Tests.java line 5464:
>
>> 5462:
>> 5463: @Test
>> 5464: static void equalsNaNFloat16Vector128TestsSmokeTest() {
>
> Ideally we would also test as a non-smoke test. Can we add those two `NaN`
> values to the set of corner cases? That will likely shake out any more
> remaining issues (hopefully there are none).
>
> There is also `hashCodeFloat16Vector256TestsSmokeTest`which I think needs to
> be updated.
>
> Then we don't need explicit tests.
Verified that with cornetCase extension existing hashcode test fails with
baseline, removing newly added tests as suggested.
@PaulSandoz , @ExE-Boss All comments addressed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31587#discussion_r3465457180
