On Mon, 22 Jun 2026 12:31:44 GMT, Du�an B�lek <[email protected]> wrote:

> `ImageReader` fails to locate preview resources in a module’s top-level 
> directory. A resource stored as
> `META-INF/preview/file.txt` should be exposed in preview mode as `file.txt` 
> matching how nested preview resources such as 
> `META-INF/preview/directory/file.txt` are exposed as `directory/file.txt`.
> 
> The problem is that the preview resource lookup path is constructed by 
> concatenating `META-INF/preview` and the requested resource path without an 
> intervening `/`. As a result, looking up `file.txt` in preview mode searches 
> for
> `META-INF/previewfile.txt` instead of `META-INF/preview/file.txt`. This 
> affected both `findResourceNode` and `containsResource`.
> 
> The proposal here is to add the missing slash when forming preview resource 
> names in `ImageReader`. This allows top-level preview resources to be found 
> and to override their non-preview counterparts when preview mode is enabled.
> 
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/31609#pullrequestreview-4545830915

Reply via email to