On Tue, 30 Jun 2026 14:34:06 GMT, Alan Bateman <[email protected]> wrote:
>> Du�an B�lek has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Modified to cover all node-cache orderings. > > src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 687: > >> 685: Node childNode = >> nodes.get(nonPreviewChildName); >> 686: assert isPreviewOnly == (childNode != >> null) : >> 687: "Inconsistent child node: " + >> nonPreviewChildName; > > Are you sure this assert is correct? I assume the directory could be cached > already so it should only assert childNode != null when preview is enabled. Yes, you are right. Good catch. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31609#discussion_r3504443701
