On Wed, 1 Jul 2026 08:41:01 GMT, Du�an B�lek <[email protected]> wrote:

>> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 687:
>> 
>>> 685:                                 Node childNode = 
>>> nodes.get(nonPreviewChildName);
>>> 686:                                 assert isPreviewOnly == (childNode != 
>>> null) :
>>> 687:                                         "Inconsistent child node: " + 
>>> nonPreviewChildName;
>> 
>> Are you sure this assert is correct? I assume the directory could be cached 
>> already so it should only assert  childNode != null when preview is enabled.
>
> Yes, you are right. Good catch.

Your update looks fine, I just wonder if a test could be added for this case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31609#discussion_r3505020715

Reply via email to