On Fri, 10 Jul 2026 17:54:23 GMT, Naoto Sato <[email protected]> wrote:
>> Sholto has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8272194: introduce faster code path for LocalDate/LocalDateTime conversion > > src/java.sql/share/classes/java/sql/Date.java line 323: > >> 321: // As there is no year 0 in the proleptic Gregorian calendar >> 322: // we also have to adjust the BC year by 1. >> 323: // 1 BC becomes year 0, 2 BC becomes year -1 and so on. > > I think you meant `GregorianCalendar` rather than "proleptic Gregorian > calendar" here? `GregorianCalendar` has no year zero, whereas the ISO > proleptic-year numbering used by `LocalDate` does. Also, there is a typo: > "Ajdust" should be "Adjust". Thank you for spotting those. I have fixed the comments as recommended. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31808#discussion_r3569728922
