On Tue, 14 Jul 2026 08:45:04 GMT, Sholto <[email protected]> wrote: >> src/java.sql/share/classes/java/sql/Timestamp.java line 561: >> >>> 559: year = 1 - calendar.get(Calendar.YEAR); >>> 560: } else { >>> 561: year = calendar.get(Calendar.YEAR); >> >> `getYear()` is still bypassed on this path. The `calendar` should only be >> used to determine the era. The year value should continue to be obtained >> through `getYear()`. > > Changed as suggested.
Can I just double check, do you think that we should be using `getYear() `for the BC path as well? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31808#discussion_r3577661161
