On Mon, 13 Jul 2026 17:48:50 GMT, Naoto Sato <[email protected]> wrote:
>> Sholto has updated the pull request incrementally with one additional commit
>> since the last revision:
>>
>> 8272194: expand dates covered by faster code path in
>> LocalDate/LocalDateTime conversion
>
> src/java.sql/share/classes/java/sql/Timestamp.java line 561:
>
>> 559: year = 1 - calendar.get(Calendar.YEAR);
>> 560: } else {
>> 561: year = calendar.get(Calendar.YEAR);
>
> `getYear()` is still bypassed on this path. The `calendar` should only be
> used to determine the era. The year value should continue to be obtained
> through `getYear()`.
Changed as suggested.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31808#discussion_r3577355595
