On Wed, 15 Jul 2026 12:14:33 GMT, Severin Gehwolf <[email protected]> wrote:
>> Arno Zeller has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Revert changes for --disable-plugin=exclude-files handling in strip-debug >> >> Reverts the following commits: >> - Cleanup (0a5f679) >> - Apply suggestion from @jerboaa (9811c6178) >> - Add check for --disable-plugin=exclude-files and disable file filtering >> in this case. (c534e2e202) > > src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/DefaultStripDebugPlugin.java > line 77: > >> 75: String pattern = debugFilePattern(in); >> 76: ExcludeFilesPlugin excludeFilesPlugin = new ExcludeFilesPlugin(); >> 77: excludeFilesPlugin.configure(Map.of(EXCLUDE_FILES_PLUGIN, >> pattern)); > > This seems to suggest if `--strip-debug` *and* > `--disable-plugin=exclude-files` are both present, the file exclusions would > still happen I don't think that should be the case. This might need changes > in `getPluginsConfig()` of `TaskHelper`. Instead users are advised to use the wanted plugins explicitly `--strip-java-debug-attributes --strip-native-debug-symbols=exclude-debuginfo-files [...]`. This is in line with how it currently works. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31690#discussion_r3614127372
