On Thu, 17 Sep 2026 14:55:00 GMT, Severin Gehwolf <[email protected]> wrote:

>> The proposal here is to:
>> - Correct the man page description of the `--module-path` option, which 
>> incorrectly suggests using of the `JAVA_HOME` environment variable. The 
>> description should be aligned with the existing wording in `jlink --help`.
>> - Expand the descriptions of the `--strip-debug` option in the man page and 
>> `jlink --list-plugins` to explain what kinds of Java and native debug 
>> information are removed from the output image.
>> - Expand the description of the `--strip-java-debug-attributes` option in 
>> `jlink --list-plugins` to explain which debug attributes are removed from 
>> class files.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> src/jdk.jlink/share/man/jlink.md line 115:
> 
>> 113:     the other standard and JDK modules. If this option is specified but 
>> the
>> 114:     `java.base` module cannot be resolved from it, then the `jlink` 
>> command
>> 115:     appends the JDK's `jmods` directory to the module path.
> 
> This seems incorrect given JEP 493, which doesn't have a `jmods` directory. 
> Perhaps use something like this instead?
> 
> 
> If this option is not specified, the JDK's default module path will be used.
> The default module path will always include the `java.base` module, either
> resolved from packaged modules (JMODS) or the run-time image (JEP 493).
> JDK external modules must always be specified using this option.

I wonder if in this case `jmods` needs to be mentioned at all.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32926#discussion_r4038896859

Reply via email to