On Thu, 17 Sep 2026 15:51:46 GMT, Pavel Rappo <[email protected]> wrote:

>> src/jdk.jlink/share/man/jlink.md line 115:
>> 
>>> 113:     the other standard and JDK modules. If this option is specified 
>>> but the
>>> 114:     `java.base` module cannot be resolved from it, then the `jlink` 
>>> command
>>> 115:     appends the JDK's `jmods` directory to the module path.
>> 
>> This seems incorrect given JEP 493, which doesn't have a `jmods` directory. 
>> Perhaps use something like this instead?
>> 
>> 
>> If this option is not specified, the JDK's default module path will be used.
>> The default module path will always include the `java.base` module, either
>> resolved from packaged modules (JMODS) or the run-time image (JEP 493).
>> JDK external modules must always be specified using this option.
>
> I wonder if in this case `jmods` needs to be mentioned at all.

Even without JEP 493, there is no guarantee that the run-time image was created 
with `--keep-packaged-modules` so it may not contain the packaged modules.

The other thing we need to get across in the description is that the "default 
module path" is appended to the path specified to `--module-path`.  I need only 
specify the location of my modules, jlink will find the dpeendences in the 
run-time image if possible. That might be using the packaged modules or the 
run-time image itself.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32926#discussion_r4039054614

Reply via email to