On Thu, 17 Sep 2026 13:18:08 GMT, Dušan Bálek <[email protected]> wrote:

> The proposal here is to:
> - Correct the man page description of the `--module-path` option, which 
> incorrectly suggests using of the `JAVA_HOME` environment variable. The 
> description should be aligned with the existing wording in `jlink --help`.
> - Expand the descriptions of the `--strip-debug` option in the man page and 
> `jlink --list-plugins` to explain what kinds of Java and native debug 
> information are removed from the output image.
> - Expand the description of the `--strip-java-debug-attributes` option in 
> `jlink --list-plugins` to explain which debug attributes are removed from 
> class files.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Changes for `--module-path` look good. Changes for stripping debug information 
look good too. The wording clearly shows what is lost if either option is 
specified. However, I defer the rest of the review to someone with the relevant 
expertise.

I have one question, though. If `--strip-java-debug-attributes` is designed as 
a subset of `--strip-debug`, it should be reflected in the documentation. 
Something along the lines: "--strip-debug has all the effects of 
--strip-java-debug-attributes and then these extra effects ...". This would 
save people time on verifying that the common text is in fact identical.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/32926#issuecomment-5715883154

Reply via email to