On Thu, 29 Oct 2026 21:46:18 GMT, Brent Christian <[email protected]> wrote:

>> Per the bug report, this change specifies the current behavior for 
>> `Properties.load()` when a key/value mapping is `load()`-ed for which the 
>> Properties already contains a mapping, or a key/value mapping occurs more 
>> than once in the `load()`-ed property list.
>> 
>> Once the wording of the spec update is agreed upon, I will copy it to the 
>> `load(InputStream inStream)` overload, and submit the CSR.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Brent Christian has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   wording tweak

src/java.base/share/classes/java/util/Properties.java line 374:

> 372:      * If the loaded property list includes a key that is already present
> 373:      * in this {@code Properties}, the associated element is set to the 
> value
> 374:      * loaded from the property list.

I wonder if you could get the word "replace" into this as I think that would 
make it clearer that the value loaded from the property list replaces the 
existing value.

In terms of placement, it seems like dealing with duplicates is more important 
and should be further up in the method description.  Maybe you've already tried 
a few options but it seems too important to put at the end after all the other 
details on escaping and line continuation,

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33638#discussion_r4421427073

Reply via email to