On Fri, 30 Oct 2026 07:36:57 GMT, Alan Bateman <[email protected]> wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> wording tweak
>
> src/java.base/share/classes/java/util/Properties.java line 374:
>
>> 372: * If the loaded property list includes a key that is already
>> present
>> 373: * in this {@code Properties}, the associated element is set to the
>> value
>> 374: * loaded from the property list.
>
> I wonder if you could get the word "replace" into this as I think that would
> make it clearer that the value loaded from the property list replaces the
> existing value.
>
> In terms of placement, it seems like dealing with duplicates is more
> important and should be further up in the method description. Maybe you've
> already tried a few options but it seems too important to put at the end
> after all the other details on escaping and line continuation,
Good ideas - updated
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33638#discussion_r4427330621
