On Fri, 30 Oct 2026 18:50:54 GMT, Brent Christian <[email protected]> wrote:
>> Per the bug report, this change specifies the current behavior for >> `Properties.load()` when a key/value mapping is `load()`-ed for which the >> Properties already contains a mapping, or a key/value mapping occurs more >> than once in the `load()`-ed property list. >> >> Once the wording of the spec update is agreed upon, I will copy it to the >> `load(InputStream inStream)` overload, and submit the CSR. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Brent Christian has updated the pull request incrementally with one > additional commit since the last revision: > > update wording + placement Hi Brent, Overall, I think it is ok, see the additional suggestion below src/java.base/share/classes/java/util/Properties.java line 240: > 238: * <p> > 239: * If a key in the loaded property list already exists in this > 240: * {@code Properties}, the associated element is replaced with the > value > * If a key in the loaded property list already exists in this * {@code Properties}, would it be clearer as > * If a key in the loaded property list already exists in this * {@code Properties}, object ------------- PR Review: https://git.openjdk.org/jdk/pull/33638#pullrequestreview-5717671994 PR Review Comment: https://git.openjdk.org/jdk/pull/33638#discussion_r4427702025
