On Thu, 19 Nov 2026 00:11:54 GMT, Justin Lu <[email protected]> wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix title mismatch
>
> src/java.xml/share/classes/jdk/xml/internal/XMLSecurityManager.java line 945:
>
>> 943: Integer iVal;
>> 944: if (map != null) {
>> 945: String stringValue = ((String)value).trim();
>
> The overall purpose of this change is to enforce stricter behavior while
> trimming white space seems to make the validation more lenient. I personally
> think it is okay if not trimmed, because invalid values fail, so excess white
> space values would be clear that they need to be corrected. It isn't a big
> deal and I'll defer to your preference.
Both to protect user intent. Whitespace is trimmed because it preserves the
user's obvious intent, whereas invalid values are rejected to protect the user
from silent misconfiguration.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/33938#discussion_r4623312665