On Thu, 19 Nov 2026 17:43:58 GMT, Justin Lu <[email protected]> wrote:
>> I'd say no need to add the "and" as there's no fallback mechanism. For the >> case where there's a dedicated validator, note that the value is in the map. > > By fallback value I meant the `unmappedValue`. > > Maybe I am misunderstanding, but as far as I can tell, given, > > `iVal = map.getOrDefault(stringValue.toLowerCase(Locale.ROOT), > unmappedValue);` > > the code implies that if the value does not exist in the map, it will use > `unmappedValue`, but if that fallback value (`unmappedValue`) is itself > `null`, only then will `IllegalArgumentException` be thrown. Which is > relevant for `RAMAPPER` because values other than "*" and "" are not in the > `RA_MAP`, but do not throw `IAE` since that mapper is given an > `unmappedValue` of `JdkConstants.ALLOW` (0). Thanks for the feedback. The impl is misleading. I've updated it with unmappedValue removed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33938#discussion_r4634639948
