On Thu, 19 Nov 2026 00:27:42 GMT, Justin Lu <[email protected]> wrote:

>> Joe Wang has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   fix title mismatch
>
> src/java.xml/share/classes/jdk/xml/internal/XMLSecurityManager.java line 936:
> 
>> 934:          * @return the mapped integer, or the configured integer 
>> representation
>> 935:          * for unmapped values
>> 936:          * @throws IllegalArgumentException if the value is not in the 
>> provided map
> 
> Should the `IAE` clause mention that it is thrown when the value is not in 
> the map **AND** there is no fallback value provided?

I'd say no need to add the "and" as there's no fallback mechanism. For the case 
where there's a dedicated validator, note that the value is in the map.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/33938#discussion_r4623392544

Reply via email to