On Fri, 20 Nov 2026 10:54:06 GMT, Armin Schrenk <[email protected]> wrote:

>> Add support for native ARM64 Windows MSI pacakges to jpackage.
>> 
>> For some reasoning and more info, check out the ticket on JBS: 
>> https://bugs.openjdk.org/browse/JDK-8361207.
>> 
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Armin Schrenk has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains four commits:
> 
>  - add tests
>  - Drop internal enum approach and only switch for Wix4 the architecture.
>  - Merge branch 'master' into JDK-8361207
>    
>    # Conflicts:
>    #  src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WixPipeline.java
>  - Add support for arm64 Platform for jpackage/WixPipeline

test/jdk/tools/jpackage/windows/WinMsiPlatformTest.java line 68:

> 66:             } else {
> 67:                 expectedPlatform = "x64";
> 68:             }

Am I right that the MSI package arch depends on the WiX version? If WiX3 is 
installed, the architecture is x64; if WiX4+ is installed, it's arm64.

Before the change, it was always x64, regardless of the WiX version.

This change breaks backward compatibility. Did you consider this implication?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26093#discussion_r4647676138

Reply via email to