ron minnich wrote:
This is a possible mod to change the way resource maps are done.

Unify the big mess into a little mess.
This code has all the functionality of the 4 or 5 rmap functions from v2 ..

This includes my proposed pci config patch.

Signed-off-by: Ronald G. Minnich <[EMAIL PROTECTED]>

I don't understand the patch. Why does having a single function for "resource maps" require pci_read_configXY to be renamed? And how does that reduce the mess?

-       nbcap = pci_read_config32(ctrl->f3, NORTHBRIDGE_CAP);
-       dcl = pci_read_config32(ctrl->f2, DRAM_CONFIG_LOW);
+       nbcap = pci_cf8_conf1.read32(NULL, 0, ctrl->f3, NORTHBRIDGE_CAP);
+       dcl = pci_cf8_conf1.read32(NULL, 0, ctrl->f2, DRAM_CONFIG_LOW);


I never saw a conf2 system since 1994, so putting this in the name is an anachronism. No conf2 system could ever work anyways without signigicantly changing the code.





--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
     Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: [EMAIL PROTECTED]  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866


Attachment: signature.asc
Description: OpenPGP digital signature

--
coreboot mailing list
[email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to