On Thu, Dec 18, 2008 at 12:58 PM, Myles Watson <[email protected]> wrote: > > > On Thu, Dec 18, 2008 at 12:21 PM, Myles Watson <[email protected]> wrote: >> >> >> On Thu, Dec 18, 2008 at 11:51 AM, Myles Watson <[email protected]> wrote: >>> >>> >>> On Thu, Dec 18, 2008 at 11:41 AM, Marc Jones <[email protected]> wrote: >>>> >>>> On Wed, Dec 17, 2008 at 1:42 PM, Myles Watson <[email protected]> wrote: >>>> > serengeti.diff and dtc-links.diff make serengeti find all of its >>>> > devices >>>> > correctly. >>>> > >>>> > serengeti.diff >>>> > - takes out the multiple links for the Opteron (they weren't working >>>> > correctly) >>>> > - adds the 8132 devices and makes them pci_a so they don't conflict >>>> > with the >>>> > 8111 >>>> > - corrects the disabled flags (I think we should have a build error >>>> > somewhere when there are incorrect flags) >>>> > - moves the lpc device to the lpc bus >>>> > - adds back in the second Opteron >>>> > >>>> > Signed-off-by: Myles Watson <[email protected]> >>>> > >>>> >>>> Acked-by: Marc Jones <[email protected]> >>>> But what about amd8151? > > I was thinking the 8151 was on a different link of the same Opteron. It's > not. Since it's on a different Opteron, it's easy. Sorry for the > confusion. > > This patch adds the 8151 and makes it compile. Tested on the free version, > so the 8151 just gets disabled. > > Signed-off-by: Myles Watson <[email protected]> > > BTW: it still needs the dtc patch. If you don't have it, this adds yet > another case where two links are created instead of one.
It would be unusual for two IO bridges to be on the same CPU. I can't think of every seeing that. I have no way to test this now but it looks good so, let's get your work in. This ack is for the dts and the dtc changes. Acked-by: Marc Jones <[email protected]> -- coreboot mailing list: [email protected] http://www.coreboot.org/mailman/listinfo/coreboot
