On Sat, May 16, 2009 at 02:07:34PM +0200, Patrick Georgi wrote:
> The northbridge code is already an improvement to before, where it was
> in the mainboard code.
> I _think_, tolmk is only available in the northbridge (and mainboard
> code called from there), so this code moved there instead of some truly
> generic place.
>
> I'm very open to a more generic solution.
In the same file, right below the HIGH_TABLES stuff is:
/* TODO: Hole needed? */
ram_resource(dev, idx++, 0, 640); /* First 640k */
/* Leave a hole for VGA, 0xa0000 - 0xc0000 */
ram_resource(dev, idx++, 768,
(tolmk - 768 - CONFIG_VIDEO_MB * 1024));
The high table stuff should just read through the "ram_resource" data
structures. (It should find the highest 64KiB of ram that is less
than 4GiB.) This can be done without any chipset or mainboard
specific code.
-Kevin
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot
