On Sat, 16 May 2009 08:34:12 +0200, Patrick Georgi <[email protected]>
wrote:
> Am 16.05.2009 04:01, schrieb Kevin O'Connor:
>>> +
>>> +#if HAVE_HIGH_TABLES == 1
>>> + high_tables_base = (tolmk - HIGH_TABLES_SIZE) * 1024;
>>> + high_tables_size = HIGH_TABLES_SIZE* 1024;
>>> + printk_debug("tom: %lx, high_tables_base: %llx,
>>> high_tables_size:
> %llx\n", tomk*1024, high_tables_base, high_tables_size);
>>> +#endif
>>> +
>>
>> The above is not correct. It places the high tables over the vga
>> memory.
> Shouldn't VGA memory be excluded from tolmk, too?
>
Yes, this HAS to be done before anything else, and then if you have SMM
enabled you have to allocate TSEG space just under VGA memory. Otherwise I
think the the High Tables can go any where under that.
--
Thanks,
Joseph Smith
Set-Top-Linux
www.settoplinux.org
--
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot