On Tue, Sep 07, 2010 at 09:10:27AM +0200, Patrick Georgi wrote:
> Am 07.09.2010 01:24, schrieb Kevin O'Connor:
> > +#ifdef CARTEST
> >     movl    REAL_XIP_ROM_BASE, %esi
> >     movl    %esi, %edi
> >     movl    $(CONFIG_XIP_ROM_SIZE>>2), %ecx
> >     rep     lodsl
> > +#endif
> Can this be removed altogether then?

The next few lines in the file also reference CARTEST:

#ifdef CARTEST
        movl    REAL_XIP_ROM_BASE, %esi
        movl    %esi, %edi
        movl    $(CONFIG_XIP_ROM_SIZE>>2), %ecx
        rep     lodsl
#endif

        /* The key point of this CAR code is C7 cache does not turn into
         * "no fill" mode, which is not compatible with general CAR code.
         */

        movl    $(CacheBase + CacheSize - 4), %eax
        movl    %eax, %esp

#ifdef CARTEST
testok: 
        post_code(0x40)
...

I think anyone wanting to run with CARTEST will want the rom preloaded
(to ensure they're doing an accurate test).

-Kevin

-- 
coreboot mailing list: [email protected]
http://www.coreboot.org/mailman/listinfo/coreboot

Reply via email to