> Any particular reason those patches were not upstreamed? Because a person who submitted these patches did not fix some problems, if you scroll down to comments at https://review.coreboot.org/#/c/coreboot/+/19820/
Paul Menzel May 23, 2017 Patch Set 1: (2 comments) src/mainboard/asus/kgpe-d16/romstage.c Line 96: Add macro or set `dev = PCI_DEV(0, 0x14, 4)`? Line 118: Line length? Arthur Heymans May 23, 2017 Patch Set 1: (5 comments) Change looks good, just pci_def.h macros that could be used a bit more. src/mainboard/asus/kgpe-d16/romstage.c Line 93: Use macros? Line 101: #define TEMP_PCI_BUS 0x1 Line 101: PCI_SECUNDARY_BUS Line 102: PCI_SUBORDINATE_BUS Line 103: PCI_BASE_ADDRESS_4 On Sun, Feb 25, 2018 at 6:01 AM, Thierry Laurion <[email protected]> wrote: > Any particular reason those patches were not upstreamed? > > > Le ven. 23 févr. 2018 21:40, Thierry Laurion <[email protected]> a > écrit : >> >> Timothys patches were mot included un coreboot >> https://review.coreboot.org/#/c/coreboot/+/19822/ >> >> Le ven. 23 févr. 2018 17:40, Elisenda Cuadros <[email protected]> a écrit : >>> >>> Hello, >>> >>> Thank you for your reply. >>> >>> I reflashed (same build) the BMC module with a hotplug. Now it works >>> like a charm, it got an ip, I can log through ssh, reboot, etc.. >>> >>> But now I have a new problem. If I try to boot from a halted system, >>> with BMC module attached, the system fires up but Coreboot hangs: >>> >>> Unable to detect valid memory on any nodes. Halting! >>> mct_d: fatalexit >>> >>> If I remove the BMC module the system boots fine. >>> >>> I have 4 Micron MT18JSF25672PDZ-1G4F1DD modules, located in CPU1 orange >>> slots. >>> >>> I attach both console logs. >>> >>> Regards, >>> >>> - Eli >>> >>> >>> >>> On 22/02/18 22:36, Timothy Pearson wrote: >>> > Actually, for OpenBMC work, hotplugging is often the only way to go. >>> > Just be very careful to align the pins correctly the first time; you >>> > don't have a second chance if you misalign the pins and fry the >>> > module... >>> > >>> > On 02/22/2018 03:22 PM, [email protected] wrote: >>> >> On 02/17/2018 09:46 AM, Elisenda Cuadros wrote: >>> >> >>> >>> Hi, >>> >>> >>> >>> Now I trying to use your OpenBMC port. >>> >>> >>> >>> I followed the instructions and everything was fine (compiling, >>> >>> reading and flashing). I waited several minutes after flashing, but >>> >>> the module didn 't blinked like in the vendor rom, nor did it receive >>> >>> an ip. >>> >>> >>> >>> I halted the system because I thought maybe it needs a cold start. >>> >>> >>> >>> After this, the system doesn't boot with the module plugged in. The >>> >>> fans begin to spin for approximately 1/4 second, but nothing else. >>> >>> >>> >>> My two fans (1 cpu & 1 chassis) have 3 pins and are low speed >>> >>> (~1000rpm) >>> >>> >>> >>> In the case I have to reflash the module, is it possible to hotplug >>> >>> it? >>> >> Hotplugging is dangerous and not supported, don't do it. >>> >>> Thank you very much for your support. >>> >> You can use a test clip to externally flash it via a flashing device >>> >> (not sure which can do 16 pins though, I would inquire on the flashrom >>> >> mailinglist) >>> >> >>> >> Are you using the latest coreboot? AFAIK coreboot was patched to >>> >> support >>> >> OpenBMC, so you need a new version with the patches. >>> -- >>> coreboot mailing list: [email protected] >>> https://mail.coreboot.org/mailman/listinfo/coreboot > > > -- > coreboot mailing list: [email protected] > https://mail.coreboot.org/mailman/listinfo/coreboot -- coreboot mailing list: [email protected] https://mail.coreboot.org/mailman/listinfo/coreboot
