No problems. It took me several patches but I think I better understand the coding style and project layout now, and tests are passing after a rebase of the code and responding to review feedback.
Thanks all for taking the time to review and for putting up with the spam :) James On Mon, Feb 26, 2018 at 12:11:09PM -0600, Timothy Pearson wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Thank you! If you have questions during the process please feel free to > ask. > > On 02/26/2018 04:53 AM, James Hebden wrote: > > On Sun, Feb 25, 2018 at 04:25:23AM -0600, Timothy Pearson wrote: > >> On 02/25/2018 02:18 AM, Mike Banon wrote: > >>>> Any particular reason those patches were not upstreamed? > >>> > >>> Because a person who submitted these patches did not fix some problems, > >> > >> I'm aware of this. Upstreaming was never part of the original funding > >> effort and I haven't had any spare time to try to work on it; been > >> working on several other projects in what little spare time I have had > >> over the past year. If anyone else would like to apply the recommended > >> cleanups and resubmit I'm fine with that. > > > > I've taken a swing at pushing a patch to address reviewer comments. > > First time submitting to CoreBoot, fingers crossed :) > > > > https://review.coreboot.org/#/c/coreboot/+/19820/ > > > > Best, > > James > > > - -- > Timothy Pearson > Raptor Engineering > +1 (415) 727-8645 (direct line) > +1 (512) 690-0200 (switchboard) > https://www.raptorengineering.com > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1 > > iQEcBAEBAgAGBQJalE26AAoJEK+E3vEXDOFb068IAJlWLPutfey4ThKYfKAsUfda > 7DTt0d+xL6qwY0jg7XRYnsYSLftGGTMPcbz/c5+aNKBO3EtYsKAiFgQZexvUP0gY > jyayYj0b3sDwE6CYParO1iU5WZ4cHOD5B5qRKry2R0drpvsH/We/ZmTwRLPl4Saq > GEvmcPEomnKM5mS8eNiaAUWRHS36WVoE9KIEdsN26LflhRqELMl3oxFamRQbIoqY > b+CReKnP7rCFt57ZtFjANAMnRkMU1hAGF2tTSK/WTVafwUwRwpm9vdKDuE4a1nJe > h3UOiP8MS0IxsAL1mftyPklpmmtXE2I14OZ11C/tKJOBslDyq1Wut9xMuwOp1xc= > =tSb+ > -----END PGP SIGNATURE----- > > -- > coreboot mailing list: [email protected] > https://mail.coreboot.org/mailman/listinfo/coreboot
signature.asc
Description: PGP signature
-- coreboot mailing list: [email protected] https://mail.coreboot.org/mailman/listinfo/coreboot
