Here is a tiny example patch which should solve this issue by removing
"return;" : "Still print this message but don't abort prematurely" (
could also submit via gerrit but only a day later ). I got it at
Lenovo G505S but everything is working fine despite this annoying
message - at least while using this laptop's internal PS/2 keyboard
(haven't tried a USB yet). Initially I thought it's coming from
SeaBIOS, but after researching indeed it comes from this
"./coreboot/payloads/libpayload/drivers/i8042/keyboard.c" place you've
mentioned.
Solve a keyboard initialization problem by not aborting prematurely
if its' reset has failed.
Signed-off-by: Mike Banon <mikebdp2 at gmail.com>
---
diff --git a/payloads/libpayload/drivers/i8042/keyboard.c
b/payloads/libpayload/drivers/i8042/keyboard.c
index 12255fb..b34dbca 100644
--- a/payloads/libpayload/drivers/i8042/keyboard.c
+++ b/payloads/libpayload/drivers/i8042/keyboard.c
@@ -321,7 +321,6 @@ void keyboard_init(void)
ret = keyboard_cmd(I8042_KBCMD_RESET);
if (ret != I8042_KBCMD_ACK) {
printf("ERROR: Keyboard reset failed ACK: 0x%x\n", ret);
- return;
}
/* Set scancode set 1 */
On Tue, Jun 4, 2019 at 8:14 AM Joel Kitching via coreboot
<[email protected]> wrote:
>
> I think we are also seeing this issue after downstreaming:
> https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+/1637073
>
> +Matt Delco posted some comments on this CL.
>
> On Tue, Jun 4, 2019 at 1:11 PM Martin Kepplinger <[email protected]> wrote:
>>
>> Hi,
>>
>> Just tested a build using this config:
>> https://github.com/merge/skulls/blob/master/x230/nonfree-defconfig-139b3cef03
>> with a recent coreboot (my master branch HEAD is at 0da3a8a91b
>> soc/intel/baytrail: set default VBIOS filename and PCI ID)
>>
>> When selecting "3" or "4" for the secondary payloads like coreinfo in
>> Seabios, I always hit this:
>> payloads/libpayload/drivers/i8042/keyboard.c: printf("ERROR:
>> Keyboard
>> reset failed ACK: 0x%x\n", ret);
>>
>> I get "ERROR: Keyboard reset failed ACK: 0x1".
>>
>> and I basically have to shutdown.
>>
>> what's wrong? I think commit 7ae606f57f0b3d450ae748141b0e2367041b27d3
>> Paul?
>>
>> thanks,
>> martin
>> _______________________________________________
>> coreboot mailing list -- [email protected]
>> To unsubscribe send an email to [email protected]
>
> _______________________________________________
> coreboot mailing list -- [email protected]
> To unsubscribe send an email to [email protected]
diff --git a/payloads/libpayload/drivers/i8042/keyboard.c b/payloads/libpayload/drivers/i8042/keyboard.c
index 12255fb..b34dbca 100644
--- a/payloads/libpayload/drivers/i8042/keyboard.c
+++ b/payloads/libpayload/drivers/i8042/keyboard.c
@@ -321,7 +321,6 @@ void keyboard_init(void)
ret = keyboard_cmd(I8042_KBCMD_RESET);
if (ret != I8042_KBCMD_ACK) {
printf("ERROR: Keyboard reset failed ACK: 0x%x\n", ret);
- return;
}
/* Set scancode set 1 */
_______________________________________________
coreboot mailing list -- [email protected]
To unsubscribe send an email to [email protected]
