Dear Martin,
On 06/04/19 12:01, Paul Menzel wrote: > On 06/04/19 07:10, Martin Kepplinger wrote: > >> Just tested a build using this config: >> https://github.com/merge/skulls/blob/master/x230/nonfree-defconfig-139b3cef03 >> with a recent coreboot (my master branch HEAD is at 0da3a8a91b >> soc/intel/baytrail: set default VBIOS filename and PCI ID) >> >> When selecting "3" or "4" for the secondary payloads like coreinfo in >> Seabios, I always hit this: >> payloads/libpayload/drivers/i8042/keyboard.c: printf("ERROR: Keyboard >> reset failed ACK: 0x%x\n", ret); >> >> I get "ERROR: Keyboard reset failed ACK: 0x1". >> >> and I basically have to shutdown. > > The message is indeed unintended, but I am pretty sure it’s not > the reason for you to have to shut down. Matt Delco pointed out > that the the function `keyboard_cmd()` does not return the > response code but true or false. I missed that. Reading the diff again, indeed a `return` was added in case of failure, so the commit could cause the problem you described. >> what's wrong? I think commit 7ae606f57f0b3d450ae748141b0e2367041b27d3 >> Paul? > > Did you test if everything works, if you revert the commit? > > Did the PS/2 keyboard work before when loading libpayload > based payloads from SeaBIOS or GRUB (chainloader)? I’ll submit a fix to check true/false. Kind regards, Paul
smime.p7s
Description: S/MIME Cryptographic Signature
_______________________________________________ coreboot mailing list -- [email protected] To unsubscribe send an email to [email protected]
