I can test later but I think I can see what happens. It fixes the issue,
but still prints "ERROR: Keyboard set scancode failed!".
If we know that it's no error on at least one platform, we shouldn't
print "ERROR" IMO, but as long as the bug gets fixes, I guess I'm fine.
thanks
martin
On 05.06.19 07:53, Mike Banon wrote:
> Martin, could you please check what happens if you apply this patch
> but then remove a return that follows ""ERROR: Keyboard set scancode
> failed!" ? Perhaps we'll have to do the same for all these returns :
> "Still print this message but don't abort prematurely"
>
> Signed-off-by: Mike Banon <mikebdp2 at gmail.com>
> ---
> diff --git a/payloads/libpayload/drivers/i8042/keyboard.c
> b/payloads/libpayload/drivers/i8042/keyboard.c
> index 240385ce6d..c81392ab72 100644
> --- a/payloads/libpayload/drivers/i8042/keyboard.c
> +++ b/payloads/libpayload/drivers/i8042/keyboard.c
> @@ -328,7 +328,6 @@ void keyboard_init(void)
> ret = keyboard_cmd(I8042_KBCMD_SET_SCANCODE);
> if (!ret && !CONFIG(LP_PC_KEYBOARD_IGNORE_INIT_FAILURE)) {
> printf("ERROR: Keyboard set scancode failed!\n");
> - return;
> }
>
> ret = keyboard_cmd(I8042_SCANCODE_SET_1);
>
> On Wed, Jun 5, 2019 at 8:34 AM Martin Kepplinger <[email protected]> wrote:
>>
>> Am 04.06.2019 13:59 schrieb Paul Menzel:
>>> Dear coreboot folks,
>>>
>>>
>>> On 06/04/19 12:15, Paul Menzel wrote:
>>>
>>>> On 06/04/19 12:01, Paul Menzel wrote:
>>>>
>>>>> On 06/04/19 07:10, Martin Kepplinger wrote:
>>>>>
>>>>>> what's wrong? I think commit
>>>>>> 7ae606f57f0b3d450ae748141b0e2367041b27d3
>>>>>> Paul?
>>>>>
>>>>> Did you test if everything works, if you revert the commit?
>>>>>
>>>>> Did the PS/2 keyboard work before when loading libpayload
>>>>> based payloads from SeaBIOS or GRUB (chainloader)?
>>>>
>>>> I’ll submit a fix to check true/false.
>>>
>>> Furquan created a fix [1] and it was accepted and is now in the
>>> master branch.
>>>
>>> Please verify, if it works for you now.
>>>
>>>
>>> Kind regards,
>>>
>>> Paul
>>>
>>>
>>> [1]: https://review.coreboot.org/c/coreboot/+/33185
>>
>> Testing that on the X230, I get:
>>
>> "ERROR: Keyboard set scancode failed!" and keyboard does not work at
>> all, in said payloads.
>>
>> Also, reverting https://review.coreboot.org/c/coreboot/+/32951/ (
>> 7ae606f57f0b3d450ae748141b0e2367041b27d3 )
>> fixes the problem.
>>
>> Please fix this. I also think we can not return early when "RESET"
>> fails. Why not just (try to) reset silently, if possible?
>>
>> thanks,
>>
>> martin
>>
_______________________________________________
coreboot mailing list -- [email protected]
To unsubscribe send an email to [email protected]
