Am 04.06.2019 13:59 schrieb Paul Menzel:
Dear coreboot folks,


On 06/04/19 12:15, Paul Menzel wrote:

On 06/04/19 12:01, Paul Menzel wrote:

On 06/04/19 07:10, Martin Kepplinger wrote:

what's wrong? I think commit 7ae606f57f0b3d450ae748141b0e2367041b27d3
Paul?

Did you test if everything works, if you revert the commit?

Did the PS/2 keyboard work before when loading libpayload
based payloads from SeaBIOS or GRUB (chainloader)?

I’ll submit a fix to check true/false.

Furquan created a fix [1] and it was accepted and is now in the
master branch.

Please verify, if it works for you now.


Kind regards,

Paul


[1]: https://review.coreboot.org/c/coreboot/+/33185

Testing that on the X230, I get:

"ERROR: Keyboard set scancode failed!" and keyboard does not work at all, in said payloads.

Also, reverting https://review.coreboot.org/c/coreboot/+/32951/ ( 7ae606f57f0b3d450ae748141b0e2367041b27d3 )
fixes the problem.

Please fix this. I also think we can not return early when "RESET" fails. Why not just (try to) reset silently, if possible?

thanks,

                                     martin
_______________________________________________
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-le...@coreboot.org

Reply via email to