>>>>> On Fri, 24 Oct 2008 06:55:47 +0200, "Gabor Szabo" <[EMAIL PROTECTED]> 
>>>>> said:

   > so Andras, please decide. Shall I work on trunk or on a branch?

Your first change was to rip out code into a separate file. I see no
problem doing this in the trunk *if* it is being done with discipline
and no code changes are hidden in the large diff.

But two tiny code changes slipped in and this should really never
happen.

So please don't do that, neither in trunk nor in branch. Nobody could
merge your changes back if the subject line says "move CPAN::Shell
into a separate file" but really means "... and I had some brilliant
tiny and absolutely harmless ideas while doing that so I snuck them
in".

The other thing to mention is that SVN sucks and practically is only
useable when you use a frontend like svk or git. SVN as it stands
really demands working on branches for middle sized changes. I invited
you to do the tiny changes in the trunk. I'd say your next less
trivial changes should always be tried out in a branch and then merged
in when their time is ripe.

-- 
andreas

Reply via email to