On Fri, Oct 24, 2008 at 7:25 AM, Andreas J. Koenig <[EMAIL PROTECTED]> wrote: >>>>>> On Fri, 24 Oct 2008 06:55:47 +0200, "Gabor Szabo" <[EMAIL PROTECTED]> >>>>>> said: > > > so Andras, please decide. Shall I work on trunk or on a branch? > > Your first change was to rip out code into a separate file. I see no > problem doing this in the trunk *if* it is being done with discipline > and no code changes are hidden in the large diff. > > But two tiny code changes slipped in and this should really never > happen. > > So please don't do that, neither in trunk nor in branch. Nobody could > merge your changes back if the subject line says "move CPAN::Shell > into a separate file" but really means "... and I had some brilliant > tiny and absolutely harmless ideas while doing that so I snuck them > in". > > The other thing to mention is that SVN sucks and practically is only > useable when you use a frontend like svk or git. SVN as it stands > really demands working on branches for middle sized changes. I invited > you to do the tiny changes in the trunk. I'd say your next less > trivial changes should always be tried out in a branch and then merged > in when their time is ripe.
ok, so I branch and let you know when I am finished with a branch so you can decide if it is good for merging. Just for my education. I went over the change again and I saw some necessary structural changes such as the removal of the extra call to package CPAN::Shell and if I understand the two little changes you mentioned are: 1) Adding $VERSION = "5.5" to CPAN::Shell 2) and adding parentheses to CPAN::_sqlite_running() without these changes the test suit did not pass. So do you suggest that next time I should make these small changes first and then the moving of the code to separate file? regards Gabor
