On Fri, Oct 24, 2008 at 2:19 AM, Gabor Szabo <[EMAIL PROTECTED]> wrote: > 1) Adding $VERSION = "5.5" to CPAN::Shell > 2) and adding parentheses to CPAN::_sqlite_running() > > without these changes the test suit did not pass. > > So do you suggest that next time I should make these small > changes first and then the moving of the code to separate file?
Personally, I'd probably do them in the reverse order. Commit 1: break into separate file Commit 2: fix problems That way the commits are semantically clean. Think about what it will take to merge the branch later with any bug fixes to CPAN::Shell in the trunk. I think that's (a) split out CPAN::Shell in trunk then (b) merge that file (with fixes) with your changes. David
