Mark Powers wrote: > Anthony Scarpino wrote: >> Please take a look at the code and submit comments by Oct 24th for bug: >> >> 4911870 pkcs11_softtoken crypto should be factored out into a new >> library to support $PLATFORM & $HWCAP >> >> http://cr.opensolaris.org/~izick/softcrypto/ >> >> This moves aes, arcfour, des, bignum, and nylon modes out of >> pkcs11_softtoken and into libsoftcrypto; as well as, create >> platform-specific libraries for sun4u, sun4v, and i386 SSE/MMX. >> >> thanks... >> >> Tony >> _______________________________________________ >> crypto-discuss mailing list >> crypto-discuss at opensolaris.org >> http://mail.opensolaris.org/mailman/listinfo/crypto-discuss >> > > Tony, > > Why was the mode code factored out? > It has no platform-specific code. > > Otherwise, LGTM. > > Mark
It's not so much that it's platform-specific, it's that the algorithms are in libsoftcrypto.. There just happens to be platform specific libraries associated with it.. When compiling algorithm functions were calling the modes. In particular, ctr_mode_final and ctr_init_ctx were two. I think it makes sense though, if libsoftcrypto contains the algorithm code, the modes should be there.. pkcs11_softtoken is more of a pkcs11 shell.. does that make sense? if you feel I'm missing something here, by all means fire away :)
