Dan Anderson wrote: >> I have updated the webrev, at a slightly different location: >> http://cr.opensolaris.org/~izick/softcrypto-1/ > > LGTM, except for one nit: > > DEA-2: usr/src/lib/pkcs11/libsoftcrypto/i386/Makefile > Minor: you define BIGNUM_PSM_SRC in line 32, so you should use it in line 44 > (otherwise, it seems like you don't need BIGNUM_PSM_SRC at all, as it's not > used in ../Makefile.com): > > 32 BIGNUM_PSM_SRC= $(BIGNUM_DIR)/i386/bignum_i386.c > . . . > 44 $(COMPILE.c) $(BIGNUM_FLAGS) -o $@ $(BIGNUM_DIR)/i386/bignum_i386.c
That's not just a nit.. that whole BIGNUM_PSM_SRC it not suppose to be there.. I removed all that code, but apparently from only my x86 workspace.. thanks for see that.. I've updated the webrev to show the right setup which has no optimizations..
