Anthony Scarpino wrote: > Please take a look at the code and submit comments by Oct 24th for bug: > > 4911870 pkcs11_softtoken crypto should be factored out into a new > library to support $PLATFORM & $HWCAP > > http://cr.opensolaris.org/~izick/softcrypto/ >
KY-1 Can you include the PSARC case in the webrev? I looked up the case, PSARC 2006/684, and the exported interfaces have changed. So, that case needs an update. KY-2 I don't see all the changes needed to support $HWCAP for the x86/amd64 libraries. For example, common/bignum/i386/bignum_i386_asm.s contains both SSE2 and regular versions of several functions; usr/src/common/bignum/i386/bignum_i386.c selects which one to use based on the presence or absence of SSE2 support on the host. That file will need to broken up so that the generic version is not tagged as requiring SSE2 support. See bug #6330877 for a complete description of the issue. -Krishna
