Anthony Scarpino wrote: > Krishna Yenduri wrote: >> Anthony Scarpino wrote: >>> I have updated the webrev, at a slightly different location: >>> http://cr.opensolaris.org/~izick/softcrypto-1/ >>> >> usr/src/lib/pkcs11/libsoftcrypto/amd64/mapfile and other mapfiles >> >> KY-1 >> >> The convention in ON is to name them mapfile-vers. So, recommend >> renaming these files. >> >> KY-2 >> >> Since this is a private library, I would recommend making >> the symbols SUNWprivate in all of these files. >> >> See usr/src/lib/libcryptoutil/common/mapfile-vers for an example.
For what it is worth at this stage I've reviewed the full webrev as well and those were the only to remaining comments I had found. So I'm happy to be listed as a codereviewer as well. -- Darren J Moffat
