Ed Leafe wrote: > I've been looking at the code for the tests for dBizobj, and noticed > that there is incorrect code that is causing the testChildren() test > to fail. Specifically, the child bizobj's UserSQL is set, but it does > not have a filter on the parent FK. I believe that the expectation > would be that the bizobj would somehow add that filter expression as > it does when the SQL Builder approach is used, but UserSQL is just > that: the user (actually, the developer) is responsible for the code; > the framework will not modify that at all. As a result, no child > filter is set, and all child records are returned.
The tests used to work, so perhaps that expectation wasn't unfounded at the time? > Since I didn't set up these tests, I thought I'd point this out, and > let whoever is maintaining them know about this, so that they can > decide how to correct it. Either use the SQL Builder approach and > rely on the framework to do the right thing, or write UserSQL and > take responsibility for the code that gets executed. Since this is a > test of the framework, I would imagine that the former is what you > had in mind. We should write tests for all cases. So, if tests for the sqlbuilder are missing, those should be written. And if tests for UserSQL are broken, those should be fixed. But it isn't either/or. -- pkm ~ http://paulmcnett.com _______________________________________________ Post Messages to: [email protected] Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev Searchable Archives: http://leafe.com/archives/search/dabo-dev This message: http://leafe.com/archives/byMID/dabo-dev/[EMAIL PROTECTED]
