Hi,

Am 22.01.2014 13:05, schrieb Torsten Bronger:
> Lensfun uses a scoring algorithm that measures the similarity(tm) of
> the lens names.  In this case, the non-ED variant would win, because
> fewer additional words.  But isn't Darktable reporting a longer lens
> model name?

Darktable reports the lens name "OLYMPUS 14-42mm Lens" for the lens

Exif.OlympusEq.LensType                      Byte        6  Olympus
Zuiko Digital ED 14-42mm F3.5-5.6
Exif.OlympusEq.LensSerialNumber              Ascii      32  212686538
Exif.OlympusEq.LensModel                     Ascii      32  OLYMPUS
14-42mm Lens
Exif.OlympusEq.LensFirmwareVersion           Long        1  4869
Exif.OlympusEq.LensProperties                Short       1  49223

and, in the same way, the (way too unspecific) Exif.OlympusEq.LensModel
data for the other two FT lenses. I'm pretty sure, that somewhere some
part of the code should say "oh, this is a FT lens, I'll use the data
from Exif.OlympusEq.LensType.

Given the data, that I quoted for the "Olympus
M.Zuiko Digital ED 12-50mm F3.5-6.3 EZ" lens and that
Exif.Photo.LensModel is set for that, but not for the FT lenses I own,
this may also work with:

<pseudocode>
if maker == "Olympus":
        if isset(Exif.Photo.LensModel):
                return Exif.Photo.LensModel
        else:
                return Exif.OlympusEq.LensType
</pseudocode>

Yet, I don't know the darktable or lensfun code, so I don't know which
component has to do this.

Take care,
  Jan Niklas

------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today. 
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel

Reply via email to