Hallöchen!
Jan Niklas Fingerle writes:
> Am 22.01.2014 13:05, schrieb Torsten Bronger:
>
>> Lensfun uses a scoring algorithm that measures the similarity(tm)
>> of the lens names. In this case, the non-ED variant would win,
>> because fewer additional words. But isn't Darktable reporting a
>> longer lens model name?
>
> Darktable reports the lens name "OLYMPUS 14-42mm Lens" for the
> lens
Okay. This may mean an issue in exiv2 (full name should be also in
LensModel) or in Darktable (LensType should be used for this camera,
and probably others). In my own code, I simply use the *longest*
entry. This sounds silly but works great.
So, I must pass the question to DT core developers. The DT file in
question is src/common/exif.cc, line 534:
else if (
(pos=exifData.findKey(Exiv2::ExifKey("Exif.OlympusEq.LensModel"))) !=
exifData.end() && pos->size())
{
dt_strlcpy_to_utf8(img->exif_lens, sizeof(img->exif_lens), pos, exifData);
}
Maybe before this line, it should check "Exif.OlympusEq.LensType",
giving it higher precedence. But with my luck with EXIF, this would
break other cameras. (EXIF is one of the worst "standards" of this
planet.)
I recommend to file a bug report against DT and exiv2, just to be
sure. You may point to this email through
http://blog.gmane.org/gmane.comp.graphics.darktable.devel
Tschö,
Torsten.
--
Torsten Bronger Jabber ID: torsten.bron...@jabber.rwth-aachen.de
or http://bronger-jmp.appspot.com
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel
