Am Montag, 24. November 2014, 08:47:44 schrieb Terry Duell:
> Hello Tobias,
>
> On Mon, 24 Nov 2014 02:43:44 +1100, Tobias Ellinghaus <h...@gmx.de> wrote:
> > Am Sonntag, 23. November 2014, 12:40:52 schrieb Terry Duell:
> >> Hello All,
> >> Just feeling my way with building darktable from repo, so looking for
> >> some help.
> >> I build Fedora rpms, and successfully managed to do that for the current
> >> release candidate.
> >> I have now cloned the git repo, and tried to make a source package for
> >> an rpmbuild build, but find that using the following approach...
> >>
> >> cd darktable
> >> mkdir BUILD
> >> cd BUILD
> >> cmake ..
> >> make package_source
> >
> > make pkgsrc
> > is the intended command for us. It's defined like this:
> >
> > ADD_CUSTOM_TARGET(pkgsrc
> >
> > COMMAND ${CMAKE_COMMAND} -E copy
> >
> > ${CMAKE_BINARY_DIR}/version.cmake
> > ${CMAKE_SOURCE_DIR}/cmake/version.cmake
> >
> > COMMAND ${CMAKE_COMMAND} --build ${CMAKE_BINARY_DIR} --target
> >
> > package_source
> >
> > COMMAND ${CMAKE_COMMAND} -E remove
> >
> > ${CMAKE_SOURCE_DIR}/cmake/version.cmake )
> >
> > So it just copies the generated version.cmake into the tarball, the rest
> > is the same.
>
> OK. Is that going to be added to CmakeLists.txt?That was copy&pasted from our cmake files. > [snip] > > > The size difference is just because we manually (well, from the script > > Togan mentioned) delete the usermanual's sources to get a reasonable > > tarball size. The rest is the same. > > Why not have cmake do that? > I would propose a patch if I had enough knowledge of cmake. I know we do > it for hugin...produce a clean tarball that is. I'll have to have a look > at how that is done. Why? Just leave the docs in there. Or build from the git checkout directly. Even having that pkgsrc target is just there as a reminder that version.cmake is a requirement and to give people a way to generate a source tarball. I don't think anyone ever used it. And that tarball created is as clean as you can get it. Even more complexity in our cmake system for no reason sounds like a bad idea. > Thanks for your help. > > Cheers, Tobias
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
