I'm going to pick nits, because I'm anal. - It'd be good to name the variables that are constants either in all caps or in StudlyCaps
- You don't need to load Data::Dumper - Your editor produces satanic tabbing indentation! What are you using? When I load the code in emacs or vi it scrolls off the screen and nothing lines up. - You don't need to copy the validate into as_set. It's ok if it blows up elsewhere since (hopefully) the Params::Validate-generated error message will be clear enough to indicate the problem anyway. - fullmoon is two words so it should be full_moon. But maybe this parameter should be changed to something like "church"? After all, people don't think of the "Easter full moon". - The docs need to say what the default for the inclusive parameter is (it's implied, but not stated). Otherwise it looks good, modulo bugs ;) -dave /*======================= House Absolute Consulting www.houseabsolute.com =======================*/
