Hi Rick,
>
> Attached is Beta 2. I think I've incorporated all suggestions. If
> I've missed anything, let me know.
>
[snipped]
>
> The ->set method is now ->as_list and I've added ->as_set which
> returns a DateTime::Set object (although this isn't tested at ALL!
> CPAN wouldn't give me DateTime::Set :))
looking at your module you need to add the
use DateTime::Set to your script
Also here:
sub as_set {
my $self = shift;
# Maybe we should validate here otherwise its as_list that will
complain
return DateTime::Set->new( dates => [ $self->as_list(@_) ] );
}
I added this to my module and it did not complain :-) So do I still
need to do some validation?
Also under the SYNOPSIS section of the pod you still have
@set = $palm_sunday->set(from=>$dt, to=>$dt2, inclusive=>1);
need to change that to
@set = $palm_sunday->as_list(from=>$dt, to=>$dt2, inclusive=>1);
> The cache has been removed. This means years are sometimes
> recalculated a second later, but the memory blow-out factor isn't
> there.
>
> Thanks for all the suggestions,
>
> Cheers!
> Rick
You have done a great job on this module!! it looks good.
Thanks
Ron Hill
