Thanks Eugene! This is excellent!
On 26/3/03 8:42 am, Eugene van der Pijll at [EMAIL PROTECTED] spake thus:
> Rick Measham schreef:
>> Beta 2 includes support for Orthodox Easter, however I doubt it
>> handles it the best way possible. Please take a look and offer
>> suggestions (its the last sub before the POD). It should also be
>> noted that both Easters should return Gregorian Dates as they do now.
>
> The $potential_easter shouldn't be in eastern_easter. When called with
> year => 60000, the result is an infinite loop:
[snip]
I'll have a look at that, thanks
> What do you do with years without an Easter? Try the year 35000:
[snip]
> And what about the years with 2 Easters? Do your 'following' and
> 'previous' work for them? It looks like they work by changing the year
> by one...
Actually I woke up about 3am in a cold sweat realizing the possibility of
other-than-one-easter years.
> Best solution would perhaps to convert to Julian at the start of those
> methods, and to convert them back to Gregorian at the end.
> (DateTime::Calendar::Julian could be useful here ;-)
Yeah, I figured I might have to do that, although then rather than finding
the Easter in Julian Year 35000, I need to find it between Julian
Equivalents of Gregorian Jan 1 35000 and Gregorian Dec 31 35000. Which just
isn't so easy as calling it with a year. I'll need to call the potential
(three?) years that overlap the single Gregorian year, and then find the
Easter that intersects with the Gregorian year.
Hmmm .. I see some use for DateTime::Set::intersect there...
Anyways, because Orthodox dates require so much extra coding, and because
they require other modules, I'm considering breaking this into two modules.
if I do that, I'll also make DateTime::Event::OrthodoxEaster able to accept
both DateTime objects and DateTime::Calendar::Julian objects.
This will mean most people who only want 'Western' Easter only need
DateTime::Event::Easter. And they'll only need DateTime::Set if they use
->as_set
Speaking of which: Is there any better way to conditionally load a module
other than:
eval("use DateTime::Set");
croak("Couldn't load DateTime::Set:".$@) if $@;
> And some small points:
>
> - Documentation bug: 'fullmoon' should be 'easter' in the constructor
> options.
Thankyou, fixed
> - In the POD, your lines are longer than 80chars, which is a bit
> annoying.
LOL .. BBEdit's Hard Wrap is about to be sicked on the docs ... stand back.
Thanks for all this,
Cheers!
Rick
--------------------------------------------------------
�� � � � � � There are 10 kinds of people:
�� those that understand binary, and those that don't.
--------------------------------------------------------
�� The day Microsoft makes something that doesn't suck
�� � is the day they start selling vacuum cleaners
--------------------------------------------------------
