On 26/3/03 9:09 am, Dave Rolsky at [EMAIL PROTECTED] spake thus: > I'm going to pick nits, because I'm anal.
Picking nits is good, but I swear I showered and combed my hair this morning! > - It'd be good to name the variables that are constants either in all caps > or in StudlyCaps Will do > - You don't need to load Data::Dumper Oh poo! As you can guess I had it there for debugging at one point > - Your editor produces satanic tabbing indentation! What are you using? > When I load the code in emacs or vi it scrolls off the screen and nothing > lines up. Satan will be removed. I'll make it 3 spaces rather than 1-tab or whatever was in what I've pasted in. > - You don't need to copy the validate into as_set. It's ok if it blows up > elsewhere since (hopefully) the Params::Validate-generated error message > will be clear enough to indicate the problem anyway. OK, thanks for the clarification > - fullmoon is two words so it should be full_moon. But maybe this > parameter should be changed to something like "church"? After all, people > don't think of the "Easter full moon". The parameter has changed to 'easter', and accepts 'eastern' or 'western', Eugene pointed out that I'd left that in the docs. I'll hunt it down and kill it. > - The docs need to say what the default for the inclusive parameter is > (it's implied, but not stated). Ahh, OK. Actually the docs are currently written aimed at testing. There's no licence information or cross references to other modules or cookbook examples or... Anyways, what I'm saying is that I'll specifically say something like: If no 'easter' parameter is supplied then 'western' will be assumed. Thanks for this, Cheers! Rick -------------------------------------------------------- �� � � � � � There are 10 kinds of people: �� those that understand binary, and those that don't. -------------------------------------------------------- �� The day Microsoft makes something that doesn't suck �� � is the day they start selling vacuum cleaners --------------------------------------------------------
