Komal Shah wrote:

> Attached patch fixes/removes the debug noise and some
> misc. cleanups. If looks OK, then push to git tree.

NACK.

The cleanup looks OK, but I'm curious what you're using to verify the
functional changes.  For example, you changed the sleep behavior
slightly.  Your change is probably the right way, but it should be
validated.

Also, you made a change at the end for line-length which does a read
even when buf_len == 0.

Kevin
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to