Hi Thomas,

On Mon, May 31, 2010 at 19:44:40, [email protected] wrote:
> From: Thomas Koeller <[email protected]>
>
> The register base address for the second serial pot (UART1) was
> wrong.
>
> Signed-off-by: Thomas Koeller <[email protected]>
> ---
>  arch/arm/mach-davinci/include/mach/serial.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/include/mach/serial.h 
> b/arch/arm/mach-davinci/include/mach/serial.h
> index a584697..9f5ea76 100644
> --- a/arch/arm/mach-davinci/include/mach/serial.h
> +++ b/arch/arm/mach-davinci/include/mach/serial.h
> @@ -15,7 +15,7 @@
>
>  #define DAVINCI_MAX_NR_UARTS 3
>  #define DAVINCI_UART0_BASE   (IO_PHYS + 0x20000)
> -#define DAVINCI_UART1_BASE   (IO_PHYS + 0x20400)
> +#define DAVINCI_UART1_BASE   (IO_PHYS + 0x106000)
>  #define DAVINCI_UART2_BASE   (IO_PHYS + 0x20800)

The original address is correct for DM644x (and may be
other DaVincis) and wrong for DM365. IMO, the correct
fix would be to leave serial.h as is and #define the
correct address for DM365 before dm365_serial_platform_data
in dm365.c where the address is used.

Also, this bug is present in upstream kernel so can you
please generate a patch against Kevin's tree?

Thanks,
Sekhar
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to