On Wednesday 02 June 2010 08:22:46 Nori, Sekhar wrote:
> > Patch is against Kevin's tree.
>
> Such information (which is not relevant to the fix as such)
> should go below the --- in the patch. That way, it does not
> get included in the git logs once the patch is committed.
O.K., I will address that
> May be it is personal taste, but I like this way of fixing
> it better:
>
> diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinci/dm365.c
> index a146849..5dded5e 100644
> --- a/arch/arm/mach-davinci/dm365.c
> +++ b/arch/arm/mach-davinci/dm365.c
> @@ -1020,6 +1020,8 @@ static struct davinci_timer_info dm365_timer_info = {
> .clocksource_id = T0_TOP,
> };
>
> +#define DAVINCI_DM365_UART1_BASE 0x01D06000
> +
> static struct plat_serial8250_port dm365_serial_platform_data[] = {
> {
> .mapbase = DAVINCI_UART0_BASE,
> @@ -1030,7 +1032,7 @@ static struct plat_serial8250_port
> dm365_serial_platform_data[] = { .regshift = 2,
> },
> {
> - .mapbase = DAVINCI_UART1_BASE,
> + .mapbase = DAVINCI_DM365_UART1_BASE,
> .irq = IRQ_UARTINT1,
> .flags = UPF_BOOT_AUTOCONF | UPF_SKIP_TEST |
> UPF_IOREMAP,
Unless you insist, I would prefer to leave the define at its current place.
First of all, many people (including me) expect to find defines somewhere
near the beginning of a source file. More importantly, if a definition is
valid throughout the entire file, it is easier to later add code that also
depends on that definition, without having to move it again.
Thomas
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
