Hi Thomas, On Tue, Jun 01, 2010 at 14:36:43, [email protected] wrote: > From: Thomas Koeller <[email protected]> > > The register base address for the second serial port (UART1) was > wrong. > > Patch is against Kevin's tree.
Such information (which is not relevant to the fix as such) should go below the --- in the patch. That way, it does not get included in the git logs once the patch is committed. > > Signed-off-by: Thomas Koeller <[email protected]> > --- > arch/arm/mach-davinci/dm365.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinci/dm365.c > index a146849..5b66441 100644 > --- a/arch/arm/mach-davinci/dm365.c > +++ b/arch/arm/mach-davinci/dm365.c > @@ -41,6 +41,9 @@ > > #define DM365_REF_FREQ 24000000 /* 24 MHz on the DM365 > EVM */ > > +#undef DAVINCI_UART1_BASE /* Value in serial.h is wrong for DM365 */ > +#define DAVINCI_UART1_BASE (IO_PHYS + 0x106000) > + May be it is personal taste, but I like this way of fixing it better: diff --git a/arch/arm/mach-davinci/dm365.c b/arch/arm/mach-davinci/dm365.c index a146849..5dded5e 100644 --- a/arch/arm/mach-davinci/dm365.c +++ b/arch/arm/mach-davinci/dm365.c @@ -1020,6 +1020,8 @@ static struct davinci_timer_info dm365_timer_info = { .clocksource_id = T0_TOP, }; +#define DAVINCI_DM365_UART1_BASE 0x01D06000 + static struct plat_serial8250_port dm365_serial_platform_data[] = { { .mapbase = DAVINCI_UART0_BASE, @@ -1030,7 +1032,7 @@ static struct plat_serial8250_port dm365_serial_platform_data[] = { .regshift = 2, }, { - .mapbase = DAVINCI_UART1_BASE, + .mapbase = DAVINCI_DM365_UART1_BASE, .irq = IRQ_UARTINT1, .flags = UPF_BOOT_AUTOCONF | UPF_SKIP_TEST | UPF_IOREMAP, -- Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
