Your message dated Wed, 20 Sep 2023 10:49:15 +0000
with message-id <e1qiulf-00fwum...@fasolo.debian.org>
and subject line Bug#1031183: fixed in grub-installer 1.196
has caused the Debian Bug report #1031183,
regarding grub-installer: postinst fails if efivarfs cannot be mounted
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1031183: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1031183
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: grub-installer
Version: 1.186
Severity: important

Hi,

On systems where efivarfs cannot be mounted, the grub installation step fails
even though it would have otherwise worked just fine skipping the mount
efivarfs command, i.e. system installation is successful with this preseed file:

  d-i partman/early_command string sed -i 's/mountvirtfs efivarfs/#/' 
/var/lib/dpkg/info/grub-installer.postinst

The relevant code in d/postinst looks as follows, suggesting the intention to
ignore failures:

  mountvirtfs efivarfs /target/sys/firmware/efi/efivars || true

However, mountvirtfs itself is exiting with 1 in case of mount errors:

  mountvirtfs () {
          fstype="$1"
          path="$2"
          if grep -q "[[:space:]]$fstype\$" /proc/filesystems && \
             ! grep -q "^[^ ]\+ \+$path " /proc/mounts; then
                  mkdir -p "$path" || \
                          die grub-installer/mounterr "Error creating $path"
                  mount -t "$fstype" "$fstype" "$path" || \
                          die grub-installer/mounterr "Error mounting $path"
                  trap "umount $path" HUP INT QUIT KILL PIPE TERM EXIT
          fi
  }
  
I'm unsure as to what the best course of action is here, but perhaps an idea is
to avoid calling "die" when mount fails for efivarfs, and log an error to
/var/log/syslog instead? Of course the relevant umount should be skipped too.

In any case, the "|| true" part in the mountvirtfs efivarfs call should
probably be dropped.

Please note that this issue is different from https://bugs.debian.org/933523.
In that case, installing grub fails *because* efivarfs does not get mounted
properly, and the surprising bit is that the mountvirtfs efivarfs call does
*not* fail for some reason. :-)

FTR here's the error I get trying to mount efivarfs manually:

  ~ # mount -t efivarfs efivarfs /target/sys/firmware/efi/efivars
  mount: mounting efivarfs on /target/sys/firmware/efi/efivars failed: 
Operation not supported

Thanks!
  ema

--- End Message ---
--- Begin Message ---
Source: grub-installer
Source-Version: 1.196
Done: Philip Hands <p...@hands.com>

We believe that the bug you reported is fixed in the latest version of
grub-installer, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1031...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Philip Hands <p...@hands.com> (supplier of updated grub-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 20 Sep 2023 11:51:31 +0200
Source: grub-installer
Architecture: source
Version: 1.196
Distribution: unstable
Urgency: medium
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Philip Hands <p...@hands.com>
Closes: 1031183
Changes:
 grub-installer (1.196) unstable; urgency=medium
 .
   * Team upload.
 .
   [ Updated translations ]
   * German (de.po) by Holger Wansing
   * Spanish (es.po) by gallegonovato
   * Hebrew (he.po) by Yaron Shahrabani
   * Indonesian (id.po) by Reza Almanda
   * Korean (ko.po) by Changwoo Ryu
   * Lithuanian (lt.po) by Rimas Kudelis
   * Norwegian Bokmal (nb.po) by Petter Reinholdtsen
   * Dutch (nl.po) by Frans Spiesschaert
   * Punjabi (Gurmukhi) (pa.po) by Aman Alam
   * Polish (pl.po) by Matthaiks
   * Portuguese (pt.po) by Miguel Figueiredo
   * Portuguese (Brazil) (pt_BR.po) by Adriano Rafael Gomes
   * Serbian (sr.po) by Filipovic Dragan
   * Swedish (sv.po) by Anders Jonsson
   * Simplified Chinese (zh_CN.po) by Boyuan Yang
 .
   [ Arnaud Rebillout ]
   * Don't fail if we can't mkdir efivars (Closes: #1031183)
 .
   [ Pascal Hambourg ]
   * grub-installer: propagate ignore_uefi flag to target system for os-prober
 .
   [ Pascal Hambourg & Philip Hands ]
   * Miscellaneous refactoring & code tidying relating to efivars changes
Checksums-Sha1:
 e773eb9dc69f87ef250df3adf361a6525a592169 2137 grub-installer_1.196.dsc
 af0583bd4adc44e9240ff5a93818e280dcedb275 244728 grub-installer_1.196.tar.xz
Checksums-Sha256:
 6b3198938407d8bfe5bebd385d3a81b0030870c5e31e40d65067005dcc6e4b6b 2137 
grub-installer_1.196.dsc
 6da32503144a27803345de6e7ee1a3e8cc36c27ea6f29ec40bcbe55debc0a7da 244728 
grub-installer_1.196.tar.xz
Files:
 e077bd0f46f919f3d45d16f3dddd305d 2137 debian-installer standard 
grub-installer_1.196.dsc
 1546cdf110de54e5f3640c2174bcdbfa 244728 debian-installer standard 
grub-installer_1.196.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE3/FBWs4yJ/zyBwfW0EujoAEl1cAFAmUKyFoPHHBoaWxAaGFu
ZHMuY29tAAoJENBLo6ABJdXA7X8QAMazzFMksZIzdOdojl4sxgeBF0odz7eYgrqL
8sXWqTXjaKoXVYsElfmjI3FqAvWPrVn0NLVgHvqBxEQTtM4yMC2G7q4HU+G4z+Fj
Ah5uMrAil4QSs22KUyxddmd/IUZFCbikS0lfe/YaSwtklAdA6OxFzek0qUDDCjTh
AsXweQZ9MF9d6ZKmnpMXQCN3qX60QbQqkW5wGabYiRe3abaZZ3QB9aqQBawkfEpk
L0S+s4pbboVhoxXcDOg/Y90zsSB4+QSiLGl4m2tVwIU11E6XeqOqfsg80Dh7Idye
A/dKJDu0eVHlPB0iTw5JH4/aJn7UzhifuRmrzyuuJgsld8doHhPVNOLh52BW39je
F8sKOTsUbDdLwprQiX29xv8uo75dmAGH4BAvt6kEgcW3cEZQQgg5tAEYLCQkgPqC
fht59sLOfhDa+oRwBp/OI8qxdJzi+GaZjczreJ/BQkRw9MCGUilKjQsWZf/DCCtW
ByF3HvMi3JV/CSOAnFNAwtJ3kL7qtE55Pz/P+2qDkYb333199kKl7ComAN2Fwm0V
ZBtczs5NyZS7Va8QjOhdTqoIvOGp9mB/Sn9FhdE8LFchm5YOjCfYUtBsVAqGSVpF
gI0EdHWj9PdQqhrAn+HFfY3B8EEYFJVZXoUH1S9/ofdF437pWJXpS0oET6tOtQ6c
pJOyJw5h
=yhX/
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to