On 2026/09/29 10:05, Maximiliano Curia wrote:
¡Hola Edmund!
Hello Maximiliano!
I checked the package and it looks good enough as to upload it.
Thank you for your time and for reviewing it!
I have a couple of suggestions for you to consider, these are not
blockers, if you the package is fine as it is, I can upload it:
- The package doesn't have autopkgtest: Currently autopkgtest is one of
the main mechanisms to detect regressions in the archive, so it's a
good idea to add them to your packages, even if they only do a
minimal smoketest. Since the package requires no compilation running
the pytests in the autopkgtest is a good idea.
Let me find out how to add this. I am all for testing!
- The package can be used as python module but the name of the package
suggests an application: The package description says "It can be
used from the command line or as a Python module.", if the later is
the main way to use this package, or if other packages might use the
python module, then it would be a good idea to split the desec-dns
binary in python3-desec-dns (python module) and desec-dns (entry point).
This might be overkill and you may want to decide this later. But, if
you later decide to split the package, it will require going through
the NEW queue again, so it make sense to think about this now.
Happy to split it into two packages, this makes sense to me.In Archlinux one can use one PKGBUILD to create several packages. Can a similar thing be done for Debian, or would this involve two repos on Salsa (e.g. one with the Python Team, and one outside of it), etc etc?
Happy hacking,
Thanks!
Kind regards,
Edmund
--
Edmund Lodewijks <[email protected]>
TZ: UTC+2 / GMT+2
OpenPGP_signature.asc
Description: OpenPGP digital signature
